Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ui.checkbox, ui.button, ui.button_group, ui.radio, ui.radio_group, ui.icon #512

Merged
merged 5 commits into from
Jun 5, 2024
Merged

feat: ui.checkbox, ui.button, ui.button_group, ui.radio, ui.radio_group, ui.icon #512

merged 5 commits into from
Jun 5, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jun 3, 2024 •
edited
Loading

The following components should now work without any direct React Spectrum dependencies:

  • ui.checkbox
  • ui.button
  • ui.button_group
  • ui.radio
  • ui.radio_group
  • ui.icon
from deephaven import ui

@ui.component
def ui_checkbox():
    return ui.checkbox("Check me")


@ui.component
def ui_button():
    return ui.button("Click me", on_press=lambda: print("Button clicked!"))


@ui.component
def ui_button_group():
    return ui.button_group(
        ui.button('One'),
        ui.button('Two')
    )


@ui.component
def ui_icon():
    return ui.icon("vsGithubAlt")


@ui.component
def ui_radio_group():
    return ui.radio_group(
        ui.radio('One', value="one"),
        ui.radio('Two', value="two"),
        label="Radio Group",
    )


@ui.component
def ui_example():
    return ui_checkbox(), ui_button(), ui_button_group(), ui_radio_group(), ui_icon(),

my_example = ui_example()

@bmingles bmingles marked this pull request as draft June 3, 2024 22:36
@bmingles bmingles force-pushed the 433-remap-ui-components branch 2 times, most recently from ac87bb8 to 74b8c0e Compare June 4, 2024 22:04
@bmingles bmingles force-pushed the 433-remap-ui-components branch from dd83603 to 551540a Compare June 5, 2024 14:50
@bmingles bmingles changed the title feat: SpectrumButton, SpectrumCheckbox, RadioGroup, ButtonGroup feat: ui.checkbox, ui.button, ui.button_group, ui.radio_group Jun 5, 2024
This was referenced Jun 5, 2024
Closed
Closed
@bmingles bmingles marked this pull request as ready for review June 5, 2024 15:29
@bmingles bmingles requested a review from mofojed June 5, 2024 15:29
@bmingles bmingles linked an issue Jun 5, 2024 that may be closed by this pull request
Remove React Spectrum dependency and remap ui components #433
Closed
@bmingles bmingles changed the title feat: ui.checkbox, ui.button, ui.button_group, ui.radio_group feat: ui.checkbox, ui.button, ui.button_group, ui.radio, ui.radio_group, ui.icon Jun 5, 2024
@bmingles bmingles mentioned this pull request Jun 5, 2024
Closed
@bmingles bmingles merged commit 6b1dbeb into deephaven:main Jun 5, 2024
19 checks passed
@bmingles bmingles deleted the 433-remap-ui-components branch June 5, 2024 16:03
mofojed added a commit to mofojed/deephaven-plugins that referenced this pull request Jun 13, 2024
@mofojed
Revert "feat: ui.checkbox, ui.button, ui.button_group, ui.radio, ui.r…
09db6a3 
…adio_group, ui.icon (deephaven#512)"

This reverts commit 6b1dbeb.
@mofojed mofojed mentioned this pull request Jun 13, 2024
Merged
mofojed added a commit to mofojed/deephaven-plugins that referenced this pull request Jun 13, 2024
@mofojed
Revert "feat: ui.checkbox, ui.button, ui.button_group, ui.radio, ui.r…
be4ee2c 
…adio_group, ui.icon (deephaven#512)"

This reverts commit 6b1dbeb.
mofojed added a commit that referenced this pull request Jun 13, 2024
@mofojed
revert: Revert some changes that are not compatible with v0.78 (#550)
27414e1 
- Need to revert some changes that require a newer version of
@deephaven/components so that we can publish a version for Enterprise V+
  - Will publish and then add these back to main
- **Revert "refactor: Cleanup component mappings and utils (python side)
(#523)"**
- **Revert "feat: Make RadioGroup orientation prop case insensitive
(#536)"**
- **Revert "feat: ui.checkbox, ui.button, ui.button_group, ui.radio,
ui.radio_group, ui.icon (#512)"**
- **Revert "chore: Update DH packages to ^0.81.1 jsapi-types to
^1.0.0-dev0.34.3 (#511)"**
- Tested with a V+ branch on Enterprise and v0.78 of `@deephaven`
packages
@mofojed mofojed mentioned this pull request Jun 13, 2024
Merged
mofojed added a commit that referenced this pull request Jun 13, 2024
@mofojed
revert: "revert: Revert some changes that are not compatible with v0.…
3502f02 
…78 (#550)" (#551)

- This reverts commit 27414e1.
- Adds back the following reverted changes:
- **Revert "refactor: Cleanup component mappings and utils (python side)
(#523)"**
- **Revert "feat: Make RadioGroup orientation prop case insensitive
(#536)"**
- **Revert "feat: ui.checkbox, ui.button, ui.button_group, ui.radio,
ui.radio_group, ui.icon (#512)"**
- **Revert "chore: Update DH packages to ^0.81.1 jsapi-types to
^1.0.0-dev0.34.3 (#511)"**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove React Spectrum dependency and remap ui components
2 participants
@bmingles @mofojed